chore: update deps and change edition to 2021 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix(WIP): core changes Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
commented
Aug 4, 2023
.github/workflows/release.yml
Outdated
Comment on lines
24
to
28
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| components: clippy, rustfmt | ||
| # Add armv7, aarch64, i686, x86_64 targets | ||
| targets: armv7-linux-androideabi, aarch64-linux-android, i686-linux-android, x86_64-linux-android |
There was a problem hiding this comment.
Should be tested on the next release.
- We should also consider running
cargo checkwith the given targets to make sure we don't find issues when we want to release a new version
elpiel
force-pushed
the
chore/update-core-and-deps
branch
from
9d3a5e4
to
18dbdb5
Compare
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
force-pushed
the
chore/update-core-and-deps
branch
from
18dbdb5
to
8a9c31e
Compare
elpiel
commented
Aug 4, 2023
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
force-pushed
the
chore/update-core-and-deps
branch
from
9c05142
to
a814f0e
Compare
sleeyax
reviewed
Aug 4, 2023
sleeyax
reviewed
Aug 4, 2023
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
commented
Aug 7, 2023
Without this change, the mentioned crates don't compile. OpenSSL has an issue with finding the RANLIB binary on the system and reflink has errors in its source which are resolved on GitHub but unpublished.
fix: patch openssl & reflink
feat: implement `StreamsPushedToStorage` and `NotificationsPushedToStorage` events
elpiel
commented
Aug 9, 2023
elpiel
commented
Aug 9, 2023
elpiel
commented
Aug 9, 2023
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
TheBeastLT
reviewed
Sep 8, 2023
| @@ -69,7 +69,7 @@ kotlin { | |||
|
|
|||
| android { | |||
| compileSdk = 33 | |||
| ndkVersion = "21.0.6113669" | |||
| ndkVersion = "25.2.9519653" | |||
There was a problem hiding this comment.
This might have an impact on our android apps, but we'll have to see. But I guess we'll need to bump it sometime.
There was a problem hiding this comment.
It has been some time that we've looked into this.
There were some problems with the android build and we had to bump up the version.
@sleeyax can also confirm that we've tested this code + indeed we have to bump it some times :)
TheBeastLT
approved these changes
Sep 8, 2023
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
elpiel
force-pushed
the
chore/update-core-and-deps
branch
from
ec57d31
to
0b39eef
Compare
Signed-off-by: Lachezar Lechev <[email protected]>
Signed-off-by: Lachezar Lechev <[email protected]>
TheBeastLT
approved these changes
Sep 11, 2023
| @@ -0,0 +1,43 @@ | |||
| use stremio_core::deep_links::LibraryItemDeepLinks; | |||
There was a problem hiding this comment.
Probably it's better to name this file as ContinueWatchingItem to match what it's working with.
sleeyax
reviewed
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamsPushedToStorageandNotificationsPushedToStorageevents #40chore: updatingChore: updatejnirequires changes tojni_extmodulejnidependency #41coreafter this PR is merged as it reverts a changed field name: feat: toggle notifications for library item stremio-core#486Use StreamingService::base_url inStream