-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/sort not watched and watched #647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachezar Lechev <[email protected]>
tymmesyde
reviewed
Mar 7, 2024
tymmesyde
approved these changes
Mar 7, 2024
elpiel
force-pushed
the
feat/sort-not-watched-and-watched
branch
2 times, most recently
from
March 8, 2024 09:35
0562ae3
to
5e9495b
Compare
Signed-off-by: Lachezar Lechev <[email protected]>
2 tasks
…into feat/sort-not-watched-and-watched
Omg, I'm so happy right now. Thank you for listening, I can't wait to see this feature available on the web! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ensapra this is continuation from your PR #642 that uses the existing
Sort
structure instead of creating a Filter.Thank you very much for your contribution!
We will be discussing the UI for web internally as well in hopes to improve the UX for using these sort options in the UI.