Update and rename ca-CA.json to ca-ES.json #699
Conversation
The language code is not correct. The current one (ca-CA) would be for Catalan spoken in Canada (I wish!), but Catalan is mostly spoken in Spain (along with Andorra, France, and Italy). A correct language code would be ca-ES (although the best practice would be a generic language code "ca.json"). Also, I corrected some typos and untranslated sentences.
|
Hi @Ecron, thanks for your contribution! I just wanted to mention this PR that already addresses the untranslated strings, and this opened issue that is related to the language code. I suggest waiting until the first PR is merged (soon hopefully), and then synchronizing yours with the other string translations + file rename. |
|
Damn it, I didn't see those, my apologies! You should totally wait until those are merged/solved. Sorry again for not checking first 😣 |
|
the issue here is that if you change a file name, all the users that ever selected "Catalan" will revert back to english (because the previous translation file / choice would no longer exist) |
|
Is it possible redirect this language to the other in the code for this specific case? Not the best solution but it will work. Or maybe keeping both files (or maybe removing the country extension?). Nevertheless, we can merge #695 first, clean this PR, and then decide what to do. |
|
The previous ones were merged (but there's a new one opened 3 weeks ago pending to be merged, not managed by me). I'm not sure what changes are still valid from this PR. Can you synchronize it with the latest changes to see the differences and put it easy to the maintainers? |
Merged changes proposed by @xeanhort in his Stremio#805, merging both Stremio#805 and Stremio#699.
|
there is really no good way to go about changing the translation filename, it will break translations for everyone that selected it before regarding this suggestion:
while possible, we don't add hacks to our code under any circumstance.. |
|
Ok! Then we have to keep the current filename. @Ecron can you keep the original file name? |
The language code is not correct. The current one (ca-CA) would be for Catalan spoken in Canada (I wish!), but Catalan is mostly spoken in Spain (along with Andorra, France, and Italy). A correct language code would be ca-ES (although the best practice would be a generic language code "ca.json").
Also, I corrected some typos and untranslated sentences.