Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set 15m Timeout to HLS.js Segment Request #35

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Set 15m Timeout to HLS.js Segment Request #35

wants to merge 1 commit into from

Conversation

jaruba
Copy link
Member

@jaruba jaruba commented Nov 13, 2022

I am not 100% certain yet, but I think the low hls.js segment request timeout may have been locking up ffmpeg processes.

@jaruba jaruba requested a review from nklhtv November 13, 2022 06:14
@jaruba
Copy link
Member Author

jaruba commented Nov 13, 2022 •
edited
Loading

Had time to look more into this, the change does help, we are currently presuming a torrent engine bug.

What happened before:

  • segment kept being requested
  • ffmpeg would lock up

What happens with this change:

  • segment is requested once
  • the torrent engine goes in idle mode after audio segments finish
  • the segment request fails with 500 http error
  • the segment is requested again
  • reignites the torrent engine
  • video playback continues

@jaruba jaruba marked this pull request as draft May 23, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklhtv nklhtv Awaiting requested review from nklhtv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jaruba