Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Filename to Video Params #40

Merged
merged 26 commits into from
May 23, 2023
Merged

Add Filename to Video Params #40

merged 26 commits into from
May 23, 2023

Conversation

jaruba
Copy link
Member

@jaruba jaruba commented Mar 29, 2023

Includes the following changes:

  • gets filename for torrents from streaming server
  • guesses filename for http streams (url.split('/').pop())
  • adds support for stream.behaviorHints.videoHash, stream.behaviorHints.videoSize, stream.behaviorHints.filename, which will overwrite the values discovered by the app

jaruba and others added 24 commits March 29, 2023 14:23
@jaruba
Add Filename to Video Params
f02d724
@jaruba
Handle Case When infoHash is Missing
21b1a1a
@jaruba
Better Handling of Case When infoHash is Missing
38dd581
@jaruba
Lint
d1ad9e0
@jaruba
Use Promise.allSettled() for Video Params
becc3da
@jaruba
Add Filename to Empty Video Params Response
d71fed2
@jaruba
Request Stats By File Index & Guess Filename for HTTP Streams
5f49070
@jaruba
Add Behavior Hints for Video Params
7e1df53
@jaruba
Lint
1ef3f1d
@unclekingpin
rename buildTorrent fn
974ad32
@unclekingpin
add infoHash and sources to createTorrent result
71cb98e
@unclekingpin
use infoHash from createTorrent result
f062e19
@unclekingpin
encode stats.json url params
fea2d7f
@unclekingpin
check typeof stream name
d5db4a9
@unclekingpin
check for video params with typeof in behavior hints
47b20db
@unclekingpin
rename convertStream result
11778fc
@unclekingpin
add fetchFilename as part of fetchVideoParams
81288e4
@unclekingpin
fetchVideoParams checks the behavior hints first
1c0e7ae
@unclekingpin
revert fetchVideoParams logic in SS middleware
c64d484
@unclekingpin
remove missing dependency
88f39f5
@unclekingpin
swap args order for fetchVideoParams
6a6591e
@unclekingpin
fix validation in withVideoParams
16a2474
@unclekingpin
fix fetchVideoParams
3289c35
@unclekingpin
initialize filename as null too
4000acf
@unclekingpin unclekingpin mentioned this pull request May 18, 2023
Closed
@jaruba jaruba merged commit 2453870 into master May 23, 2023
@elpiel elpiel deleted the add-filename-to-video-params branch June 22, 2023 14:15
@daniel-lxs
Copy link

The stremio addon sdk is still not getting the filename, it always comes as undefined
image
Is there any way around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaruba @daniel-lxs @unclekingpin