Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Async Method for Samsung Prepare #65

Merged
merged 11 commits into from
Mar 1, 2024
Merged

Conversation

jaruba
Copy link
Member

@jaruba jaruba commented Feb 22, 2024

@tymmesyde not sure how you tested this before, but it seems to work fine for me..

might have found a clean solution for this one by using an optional loaded prop

@jaruba jaruba marked this pull request as draft February 23, 2024 09:21
@jaruba jaruba marked this pull request as ready for review March 1, 2024 03:53
@jaruba jaruba requested a review from unclekingpin March 1, 2024 03:53
@jaruba jaruba merged commit c7b5462 into master Mar 1, 2024
1 check passed
@unclekingpin
Copy link
Contributor

Looks very good!
To make it safer we could store commandArgs in local variable and check if those are not changed after each async function, literally the same thing as in withStreamingServer.js
cc: @jaruba @tymmesyde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants