Guard async callbacks in TizenVideo #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclekingpin
commented
Mar 4, 2024
| @@ -574,18 +574,17 @@ function TizenVideo(options) { | |||
| switch (commandName) { | |||
| case 'load': { | |||
| if (commandArgs && commandArgs.stream && typeof commandArgs.stream.url === 'string') { | |||
| stream = commandArgs.stream; | |||
|
|
|||
| if (stream !== commandArgs.stream) { | |||
There was a problem hiding this comment.
the only thing thats missing in this PR is this check over here which allways resolve to false in the current master branch since the check is made after the update of the local stream var.
Do we need this check?
All other video implementations do command("unload") from within the body of the load action handler but maybe there is something Tizen specific here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.