Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow scrollToBottom hook to trigger when there is no scroll bar #607

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

CrudeCreations
Copy link

Hi there, just submitting this PR as I believe it should solve the issue referenced here.

Unfortunately I don't have a large enough screen to be able to recreate this issue.

Updating the hook to also check for the target's height to be greater or equal to scroll height should also trigger cb.

I don't know whether you'd want this to be an optional param or whether you think it needs a bit more work.
This may cause more calls to this callback than you'd want if 'hasNextPage' is false and the screen remains unpopulated.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@tymmesyde
Copy link
Member

Hi ! This will not work because if the clientHeight is the same height as scrollHeight, the scroll event will not be triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants