-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve webapp, improve mobile player, improve design #629
base: development
Are you sure you want to change the base?
Conversation
Hi, thank you for your PR |
It wouldn't be practical to separate it into multiple PRs as all the changes affect each other and dependant on each other. I wrote the long list to detail all the changes and make it easier to CR, but essentially there are 3 main changes:
You can try the live demo of this here: https://iedustu.github.io/stremio-web/ |
I understand that it would not be practical to separate them, we will discuss which changes we want to keep or not before you do that |
… use the original filename for the downloaded file instead of `2`
I've updated the screenshots to the latest version of this branch and detailed all the platforms and browsers I've tested this on to make sure everything works correctly. If you still find issues, let me know so I can fix them, but I think that the current version of the PR is stable and covers all the platforms and browsers I could test this on. I've attempted to maximixe the capbilities of Safari on iOS and iPadOS, and Chrome on Android, to make the PWA feel as native as possible on mobile devices, while making sure the desktop version also works great. |
I started to extensively test your PR on my android device as a PWA. One thing I noticed is that local search no longer appears under search history. I will be testing it by simply using, the coming days. Be patient as I might be slow to review everything. Have a nice weekend |
Hi. I noticed a small offset issue in the back button in the player route. Can you fix that? |
trim.C90DBB98-812E-4F9B-92E2-0F50169D1463.MOV |
@kKaskak I couldn't reproduce this issue where the back button jumps up. |
As I previously mentioned when you enter the player it's not in the same position as on other routes. |
I see what you mean. |
I've just installed the PWA app from this link on my iPad and there's no white bar at the top. |
On the ModalDialog styles, the |
I'm sure I'm running the latest version, and it still happens. |
Yes that's true. Thanks for mentioning it. |
@kKaskak Can you please share with me what version of iPadOS do you have installed and whether there are custom accessibility features enabled on your iPad? Essentially, this PR changes the <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent"> Which according to Apple's documentation makes the status bar transparent. This is how it looks on my iPad Pro 12.9" with iPadOS 17.4.1: BTW I also fixed the issue with Update: I just tested it again with my iPad updated to iPadOS 17.5.1 and I still couldn't reproduce the issue with the status bar color |
It works fine now on iPad Pro iPadOS 17.4.1 |
Buttons issue seems to be resolved too 🔥 |
@kKaskak It seems that my branch is up to date against the latest development branch and there are no conflicts |
Stremio is awesome and I use it a lot, so I wanted to add the missing features that I think would make its PWA on mobile (and on iOS and iPadOS in particular) first-class.
Changes
<video>
tagLive demo: https://iedustu.github.io/stremio-web/
Related pull requests I created for this effort
Devices and platforms tested with these changes
Add to homescreen
in the share menu in Safari)Add to homescreen
in the share menu in Safari)Screenshots
iOS web app
New mobile player design
New mobile player design on iOS
Mobile web
Desktop web
Screenshots of how it looked before (for reference)
iOS web app
Mobile player
Desktop web