fix: support http streaming server URLs #630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you try to set a streaming server URL to a URL on the local network from another machine, you'd have to use http and not https, but setting a http url as a streaming server URL on
https://web.stremio.com/#/settingsresults in the following error:stremio_core_web.js:416 Mixed Content: The page at 'https://web.stremio.com/500c80d…/scripts/worker.js' was loaded over HTTPS, but requested an insecure resource 'http://192.168.2.10:11470/device-info'. This request has been blocked; the content must be served over HTTPS.This PR fixes that by allowing the use of a http resource from Stremio web server over https.
This would make it much easier to setup a machine on the local network as a streaming server and use it from Stremio web installed as a PWA on another device.