Prevent job failure from saying there wasn't an error

On processJob error there was no return making it continue on to the success state.

lib/index.js

@@ -2,17 +2,14 @@
 
 var fs = require('fs-extra');
 var path = require('path');
-
 var _ = require('lodash');
 var async = require('async');
 var debug = require('debug')('strider-simple-runner');
 var EventEmitter2 = require('eventemitter2').EventEmitter2;
 var Loader = require('strider-extension-loader');
-
 var core = require('strider-runner-core');
-
-var cachier = require('./cachier');
 var keeper = require('dirkeeper');
+var cachier = require('./cachier');
 var JobData = require('./jobdata');
 var JobQueue = require('./jobqueue');
 var branchFromJob = require('./utils').branchFromJob;
@@ -332,7 +329,7 @@ Runner.prototype = {
     function jobDirsReady(err, dirs) {
       if (err) {
         var jobdata = self.jobdata.pop(job._id);
-        if (!jobdata) return next(null);
+        if (!jobdata) return next();
         jobdata.errored = true;
         jobdata.error = {
           message: err.message,
@@ -342,17 +339,19 @@ Runner.prototype = {
         delete jobdata.data;
         jobdata.finished = new Date();
         self.emitter.emit('job.done', jobdata);
-        next(null);
-        return;
+
+        return next();
       }
+
       self.jobdata.get(job._id).started = now;
       self.emitter.emit('browser.update', job.project.name, 'job.status.started', [job._id, now]);
       debug(`[runner:${self.id}] Job started. Project: ${job.project.name} Job ID: ${job._id}`);
       debug('Initializing plugins...');
       self.plugins(job.project.creator, config, job, dirs, function (err, workers) {
         if (err) {
           var jobdata = self.jobdata.pop(job._id);
-          if (!jobdata) return next(null);
+          if (!jobdata) return next(err);
+
           jobdata.errored = true;
           jobdata.error = {
             message: err.message,
@@ -363,14 +362,17 @@ Runner.prototype = {
           jobdata.finished = new Date();
           self.emitter.emit('job.done', jobdata);
           debug(`[runner:${self.id}] Job done with error. Project: ${job.project.name} Job ID: ${job._id}`);
-          next(null);
-          return;
+
+          return next();
         }
+
         var env = {};
+
         if (config.envKeys) {
           env.STRIDER_SSH_PUB = config.pubkey;
           env.STRIDER_SSH_PRIV = config.privkey;
         }
+
         self.config.processJob(job, workers.provider, workers.jobplugins, {
           cachier: cache,
           baseDir: dirs.base,
@@ -381,7 +383,7 @@ Runner.prototype = {
           env: env
         }, function (err) {
           var jobdata = self.jobdata.pop(job._id);
-          if (!jobdata) return next(null);
+          if (!jobdata) return next(err);
 
           if (err) {
             jobdata.errored = true;
@@ -391,13 +393,14 @@ Runner.prototype = {
             };
             self.emitter.emit('browser.update', job.project.name, 'job.status.errored', [job._id, jobdata.error]);
             debug(`[runner:${self.id}] Job done with error. Project: ${job.project.name} Job ID: ${job._id}`);
+            return;
           }
 
           delete jobdata.data;
           jobdata.finished = new Date();
           self.emitter.emit('job.done', jobdata);
           debug(`[runner:${self.id}] Job done without error. Project: ${job.project.name} Job ID: ${job._id}`);
-          next(null);
+          next();
         });
       });
     }