Set default environment variables #1045
Conversation
This allows code being run by the CI server to detect that it's running inside a CI server. The `CI` environment variable is exposed by most major CI servers, but having a vendor specific environment variable (i.e. `STRIDER`) is also common practice. For details see issue Strider-CD#892
|
This doesn't solve #892, but it's a low hanging fruit helping in a few of the scenarios where default environment variables are needed. |
|
The tests are failing :S shit |
|
As far as I remember this will not set the env vars for the environment the code is ran in. I might be wrong, did you test this manually? It looks like envs are set around here: https://github.com/Strider-CD/strider-simple-runner/blob/master/lib/index.js#L377 |
|
@knownasilya Ah good point. I'm not fully aware of how Strider will spawn the tests, but I'm 99% sure that this will not work as I intended. In which case will the |
|
I think that would be fine, also have a look at this addon, which changes the envs https://github.com/Strider-CD/strider-env/blob/master/config/config.js#L91 |
|
Oh, just realized that the file you linked to is in the strider-simple-runner repo and not this one. Is that the module that's responsible for actually executing the jobs? |
|
Exactly. |
This allows code being run by the CI server to detect that it's running inside a CI server.
The
CIenvironment variable is exposed by most major CI servers, but having a vendor specific environment variable (i.e.STRIDER) is also common practice.For details see issue #892