Devel #256
Closed
Devel #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace comm_matrix helper functions with a CommutationMatrix and overloaded linalg ops
Cleanup Special Matrices code
* identifier() -> param_indices() (Dict{Symbol, Int})
* get_identifier_indices() -> param_to_indices() (Vector{Int})
* parameters -> params (Vector{Symbol})
convert() is a proper method to call to avoid unnecessary construction, ctor semantics requires that a new object is constructed
make the type immutable
* use graph as a main parameter * simplify rows processing * don't reallocate table.columns Co-authored-by: Maximilian-Stefan-Ernst <[email protected]>
because the ParTable contains rows and columns, it is not clear, what sort() actually sorts. Co-authored-by: Maximilian-Stefan-Ernst <[email protected]>
* use named tuples * reduce code duplication * use colnames vector instead of position_names Dict
* declare RAMConstant field types * refactor constants collection to avoid code duplication
Rename SemImply to SemImplied
Switch to ProximalAlgorithms v0.7
suppress uninformative warnings during package testing
…ptional turn simplification of symbolic terms by default off
….3.0 Documentation/0.3.0
* first sweep of renaming * fix destroyed types * parameter table column renamed to label * param and param_labels, params!, seem to work * allow partial execution of unit tests * remove non existing tests * fix model unittests * remove unnessary test layer * finish replacing * all unit tests passed * rename param_values -> params * add StatsAPI as dep * add coef and coefnames * rename df => dof (#254) * rename df => dof * import dof from StatsAPI * rename dof file * rename sem_fit => fit * typo * add nobs and fix testsw * add coeftable * fix proximal tests * fix exports and StatsAPI docstrings * fix tests * fix tests * thx evie for the typo :) * fix coeftable --------- Co-authored-by: Maximilian Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.