linter: Reuse lint prepared query between lint runs #1230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows aggregating linting and standard linting to use the same prepared query. This saves around 150ms on lint runs on my laptop.
This is done by using a single entrypoint with some input 'switches' to turn things on and off depending on the linter needs at that time and to stop things being run when they aren't required in the result.
This does not make a change to the LSP integration where this could be cached even between linter instances, but sharing this PR now to check the direction etc.
I get around 3%-4% total improvement for linting the regal bundle