Rule: rule-assigns-default
#1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
reviewed
Nov 6, 2024
|
|
||
| default allow := false | ||
|
|
||
| # or just `allow if {` as `true` is implicit |
There was a problem hiding this comment.
I wonder if a non boolean example would be a good addition here too? E.g.
default cpu_shares := 0.1
cpu_shares := 0.5 if input.role == "developer"
cpu_shares := 0.1 if input.role == "intern"
Or something similar?
There was a problem hiding this comment.
ah, yes, good one... I'll amend in my next PR
charlieegan3
approved these changes
Nov 6, 2024
Flags rules where the default value is used as the assigned value in any other incremental definition. Fixes #1018 (unrelated changes mostly adding some ignore directives in Go code is from me having update golangci-lint which led to a few new issues getting reported) Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
rule-assigns-default
branch
from
75e628a to
718be70
Compare
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
Flags rules where the default value is used as the assigned value in any other incremental definition. Fixes StyraInc#1018 (unrelated changes mostly adding some ignore directives in Go code is from me having update golangci-lint which led to a few new issues getting reported) Signed-off-by: Anders Eknert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags rules where the default value is used as the assigned value in any other incremental definition.
Fixes #1018
(unrelated changes mostly adding some ignore directives in Go code is from me having update golangci-lint which led to a few new issues getting reported)