Comment and metadata rules #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments should start with a whitespace! Co-authored-by: Stephan Renatus <[email protected]> Signed-off-by: Anders Eknert <[email protected]>
This one checks that all attributes of a metadata block are valid, i.e. not custom outside of the custom map. Signed-off-by: Anders Eknert <[email protected]>
srenatus
approved these changes
Jun 29, 2023
| "entrypoint", | ||
| "custom", | ||
| } | ||
|
|
There was a problem hiding this comment.
This could become a bit of a hassle if OPA introduces further attributes. But OK for now.
There was a problem hiding this comment.
True. Not sure if there's a way to enumerate them from the Go API, but that would be preferable 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-whitespace-commentrule in thestylecategory, because comments should start with a whitespace!invalid-metadata-attributerule in thebugscategory. This one checks that all attributes of a metadata block are valid, i.e. not custom outside of the custom map.