server/springboot: alter "list tickets" SQL query on the fly #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
commented
Nov 5, 2024
| @Repository | ||
| public interface TicketRepository extends JpaRepository<Ticket, Integer> { | ||
| List<Ticket> findByTenant(Tenant tenant); |
There was a problem hiding this comment.
☝️ Before, we've let JPA figure out what SQL should be used just from the method signature.
👇 Now, we'll have to spell out the query ourselves.
One learning is that we cannot rely on the "method name to SQL query" magic that JPA supports -- rewriting queries using QueryRewriter only works for JPQL or "native" (=dialect of the database) queries. lmgty: JPQL (Java Persistence Query Language) is a query language used to perform database operations on entities defined in JPA (Java Persistence API). It is similar to SQL but operates on the entity objects instead of the database tables. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/experiment/springboot-altering-raw-sql
branch
from
b00f7e4
to
c867614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One learning is that we cannot rely on the "method name to SQL query" magic that JPA supports -- rewriting queries using QueryRewriter only works for JPQL1 or "native" (= dialect of the database) queries.
Omitted:
SQL logging uncovered a lot of queries happening for "list tickets". I'd assume that they're done automatically by Spring Data JPA, to ensure relationships etc; but it also means they are under the radar of this rewriter.
However, I'd envision that there's one rewriter that would be used with all the repositories, so maybe we would end up covering call queries after all.
Footnotes