fix: resolve linter issue #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspaink
force-pushed
the
fixlint
branch
2 times, most recently
from
71e6118
to
af6b613
Compare
anderseknert
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned the rust toolchain the same version (1.80) as the zed editor: https://github.com/zed-industries/zed/blob/main/rust-toolchain.toml
I think the github action running clippy should use this pinned version as well because it is set as
dtolnay/rust-toolchain@master, at least that is what I understood from reading the readme: https://github.com/dtolnay/rust-toolchain/tree/master?tab=readme-ov-file#inputs