Skip to content

Commit

Permalink
plugins\lib\fileconv\loaders.py unnecessary-pass
Browse files Browse the repository at this point in the history
The method parse of LoaderProto should be overridden by subclasses (as discussed with FichteFoll). Instead of leaving with just pass changed to raise NotImplementedError to verify that they are not mistakenly used.
  • Loading branch information
evidencebp authored and FichteFoll committed Nov 24, 2024
1 parent a28ddf7 commit 5f972a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/lib/fileconv/loaders.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def parse(self, *args, **kwargs):
"""To be implemented. Should return the parsed data from
``self.file_path`` as a Python object.
"""
pass
raise NotImplementedError


class JSONLoader(LoaderProto):
Expand Down

0 comments on commit 5f972a1

Please sign in to comment.