Skip to content

Commit

Permalink
[Bugfix:Developer] Fix fork Docker org name (#44)
Browse files Browse the repository at this point in the history
### Please check if the PR fulfills these requirements:

* [ ] Tests for the changes have been added/updated (if possible)
* [ ] Documentation has been updated/added if relevant

### What is the current behavior?
On PRs from forks, the Docker repo variable will not be sent to the
GitHub action. This causes the action to fail since it is missing a
required argument.

### What is the new behavior?
The action does not fail as the org name is now present.
  • Loading branch information
cjreed121 authored Aug 31, 2024
1 parent 44f92f0 commit e9c2c78
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ jobs:
uses: submitty/action-docker-build/.github/workflows/[email protected]
with:
push: false
docker_org_name: ${{ vars.docker_org_name }}
docker_org_name: submitty
base_commit: ${{ github.event.pull_request.base.sha }}
head_commit: ${{ github.event.pull_request.head.sha }}
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
uses: submitty/action-docker-build/.github/workflows/[email protected]
with:
push: true
docker_org_name: ${{ vars.docker_org_name }}
docker_org_name: submitty
base_commit: ${{ github.event.before }}
head_commit: ${{ github.event.after }}
secrets:
Expand Down

0 comments on commit e9c2c78

Please sign in to comment.