Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Autograding] Add Salsa image #49

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Conversation

ION606
Copy link
Contributor

@ION606 ION606 commented Sep 11, 2024

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

none

What is the new behavior?

we can now run salsa files

Other information?

this is not a breaking change and I tested it using some simple files (I included an example below):

module demo;

/*
   Actors with this behavior simply create a migrate actor with the specified UAN and first UAL    
   and then migrate to the second UAL.
*/
behavior Migrate {

   void print() {

      standardOutput<-println( "Migrate actor just migrated here." );
   }

   void act( String[] args ) {

         if (args.length != 3) {
                 standardOutput<-println( "Usage: java migration.Migrate  <UAN> <srcUAL> <destUAL> " );

                 return;
        }

        UAN uan = new UAN(args[0]);
        UAL ual = new UAL(args[1]);
        
        Migrate  migrateActor = new Migrate() at (uan, ual);
      
        migrateActor<-print() @ 
        migrateActor<-migrate( args[2] ) @ 
        migrateActor<-print(); 
         
   }     
    
}   

@ION606
Copy link
Contributor Author

ION606 commented Sep 11, 2024

I should note that my compilation command is java -cp $SALSA_COMPILER_JAR:. salsac.SalsaCompiler *.salsa; javac -classpath $SALSA_COMPILER_JAR:. *.java instead of java -cp $SALSAPATH/salsa$SALSAsalsac.SalsaCompiler \!*.salsa; javac -classpath $SALSAPATH/salsa$SALSAVER.jar:. \!*.java because the latter doesn't work.

If you want to test it, you can find it at https://hub.docker.com/repository/docker/ion606/salsa/general

@ION606 ION606 self-assigned this Sep 11, 2024
dockerfiles/salsa/1.1.6/Dockerfile Outdated Show resolved Hide resolved
dockerfiles/salsa/1.1.6/Dockerfile Show resolved Hide resolved
@bmcutler bmcutler merged commit be77488 into Submitty:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants