Clean up: Clarify Tinker epoch-based training configuration#20
Merged
Clean up: Clarify Tinker epoch-based training configuration#20
Conversation
Sudhendra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud.training.stepsentry fromconfigs/training.yamland clarify that Tinker run length is epoch-driven in the current training scriptdocs/AGENTS.md,docs/SETUP.md) to stop showing the obsoletesteps=300argumentTest Plan
.venv/bin/python scripts/train_tinker.py --estimate-cost --config configs/training.yaml.venv/bin/python -c "from pathlib import Path; from src.training.train_tinker import load_config_from_yaml; c=load_config_from_yaml(Path('configs/training.yaml')); print({'model': c.model, 'epochs': c.epochs, 'batch_size': c.batch_size, 'learning_rate': c.learning_rate})".venv/bin/python - <<'PY'data/training/{train,valid,test}.jsonlrecords and verify max approximate token length is below 2048 (result: max 1273)