Skip to content

Fix Tinker training for ServiceClient SDK#21

Merged
Sudhendra merged 2 commits intomainfrom
fix/tinker-serviceclient-api-key
Feb 13, 2026
Merged

Fix Tinker training for ServiceClient SDK#21
Sudhendra merged 2 commits intomainfrom
fix/tinker-serviceclient-api-key

Conversation

@Sudhendra
Copy link
Owner

Summary

  • add ServiceClient-mode training path in train_on_tinker when legacy tinker.Client is unavailable
  • pass API key via ServiceClient(api_key=...) to match current SDK requirements and avoid session init failure
  • add regression coverage for ServiceClient-only environments in tests/test_train_tinker.py

Test Plan

  • pytest tests/test_train_tinker.py tests/test_tinker_sdk_client.py tests/test_tinker_data.py -q
  • ruff check src/training/train_tinker.py tests/test_train_tinker.py

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5bae6eaf4a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Sudhendra Sudhendra merged commit 88950e1 into main Feb 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant