Fix #691 - System name not updating in system settings #718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Page inputs in 'system settings', including 'system name', are sent via post request but do not get saved as only $_GET variables are included. A variable merging $_POST and $_GET replaces $_GET when looking for values after saving the system settings. Please see the following issue:
#691
Motivation and Context
As both $_GET and $_POST variables need to be read here from different parts of the system, combining both arrays into a new variable will fix the issue.
How To Test This
'admin' -> 'system settings'
Change the system name and save
System name should be changed when going back into system settings
Types of changes
Final checklist