fix: should respect legacy decorators

[nonzzz]

TL;DR

In [email protected] the default decorators is using stage3, but it allowed using legacy decorators. difference This pull request fix fixes the wrong decorators setting and update legacy decorators unit test suite.

Relative

#66

[nonzzz]

For legacy decorator code

function trace(_target: any, _name: string, descriptor: PropertyDescriptor) {
    const original = descriptor.value;
    descriptor.value = function () {
      console.log('trace');
      return original.call(this);
    };
  
    return descriptor;
  }
  
  class People {
    xzy: string;
    constructor() {
      this.xzy = 'xzy';
    }
  
    @trace
    test() {
      return this.xzy;
    }
  }
  
  const p = new People();
  
  p.test();
  

1. tsc output

var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
    return c > 3 && r && Object.defineProperty(target, key, r), r;
};
var __metadata = (this && this.__metadata) || function (k, v) {
    if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
};
function trace(_target, _name, descriptor) {
    var original = descriptor.value;
    descriptor.value = function () {
        console.log('trace');
        return original.call(this);
    };
    return descriptor;
}
var People = /** @class */ (function () {
    function People() {
        this.xzy = 'xzy';
    }
    People.prototype.test = function () {
        return this.xzy;
    };
    __decorate([
        trace,
        __metadata("design:type", Function),
        __metadata("design:paramtypes", []),
        __metadata("design:returntype", void 0)
    ], People.prototype, "test", null);
    return People;
}());
var p = new People();
p.test();

2. swc output

function _define_property(obj, key, value) {
    if (key in obj) {
        Object.defineProperty(obj, key, {
            value: value,
            enumerable: true,
            configurable: true,
            writable: true
        });
    } else {
        obj[key] = value;
    }
    return obj;
}
function _ts_decorate(decorators, target, key, desc) {
    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
    if (typeof Reflect === \\"object\\" && typeof Reflect.decorate === \\"function\\") r = Reflect.decorate(decorators, target, key, desc);
    else for(var i = decorators.length - 1; i >= 0; i--)if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
    return c > 3 && r && Object.defineProperty(target, key, r), r;
}
function _ts_metadata(k, v) {
    if (typeof Reflect === \\"object\\" && typeof Reflect.metadata === \\"function\\") return Reflect.metadata(k, v);
}
function trace(_target, _name, descriptor) {
    const original = descriptor.value;
    descriptor.value = function() {
        console.log('trace');
        return original.call(this);
    };
    return descriptor;
}
class People {
    test() {
        return this.xzy;
    }
    constructor(){
        _define_property(this, \\"xzy\\", void 0);
        this.xzy = 'xzy';
    }
}
_ts_decorate([
    trace,
    _ts_metadata(\\"design:type\\", Function),
    _ts_metadata(\\"design:paramtypes\\", []),
    _ts_metadata(\\"design:returntype\\", void 0)
], People.prototype, \\"test\\", null);
const p = new People();
p.test();

[nonzzz]

The test snapshots did not match. I don't know why. So i have had to add new flag --update

[SukkaW]

The test snapshots did not match. I don't know why. So i have had to add new flag --update

You only need to manually update the snapshot once, you don't have to add --update to the scripts.