Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Source CLI parameters #4575

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

JSON Source CLI parameters #4575

wants to merge 4 commits into from

Conversation

kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Sep 23, 2024

Purpose of this pull request

JSON Source CLI parameters are too difficult to navigate in large tables. I pulled each parameter out and formatted them with distinct headings, specifying the field type, whether it's optional or modifiable, and any default values. Each parameter now has a concise description underneath, making it easier to scan and understand the options.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-373

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 23, 2024
@kimsauce kimsauce self-assigned this Sep 23, 2024
@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label Sep 23, 2024
@kimsauce kimsauce marked this pull request as draft September 23, 2024 20:31
@kimsauce kimsauce marked this pull request as ready for review September 25, 2024 07:02
| `sourceType` | String | Yes | | HTTP | not modifiable |
| `messagePerRequest` | Boolean | Yes | | When set to `true`, only a single message will be sent for each HTTP request. To disable this feature, set to `false`. <br/>You need to specify the common parameter `multilineProcessingEnabled` as false when setting `messagePerRequest` to `true`. | modifiable |
| `url` | String | No | URL assigned by Sumo for Source | The Source's unique HTTP endpoint web address. | not modifiable |
###### `fields`
Copy link
Collaborator

@jpipkin1 jpipkin1 Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimsauce, I like the older layout better. I find info like | JSON Object | Optional | Modifiable | listed under each parameter a little confusing. But if you want to go ahead and use the new layout, go for it.


In addition to the [common parameters](/docs/send-data/use-json-configure-sources/#common-parameters-for-log-source-types), the following parameters are specific to local file sources.

###### `sourceType`
Copy link
Collaborator

@jpipkin1 jpipkin1 Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above for the new layout of parameters in this article.

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (with minor reservations). 😄

@kimsauce kimsauce marked this pull request as draft September 25, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants