Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for masking for windows source template #4686

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Conversation

sumoanema
Copy link
Collaborator

Purpose of this pull request

This pull request is to add a doc for windows source template masking, which will be different from conventional masking process which we have for other source templates.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/SUMO-241150

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 24, 2024
@JV0812 JV0812 assigned JV0812 and sumoanema and unassigned JV0812 Oct 25, 2024
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes.

@sumoanema sumoanema marked this pull request as ready for review October 25, 2024 07:41
@sumoanema sumoanema requested a review from JV0812 October 25, 2024 07:42
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Oct 25, 2024
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @sumoanema. I made some minor changes (see commit "Updates from review").

@sumoanema sumoanema added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit d0a62b7 Nov 7, 2024
7 checks passed
@sumoanema sumoanema deleted the windowsSTMasking branch November 7, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants