feat!(metrics): move extra processors after sumologic_schema

Co-authored-by: Mikołaj Świątek <[email protected]>
SumoLogic · Sep 26, 2023 · 349f8c9 · 349f8c9
1 parent 94ac55a
commit 349f8c9
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 6 deletions.
diff --git a/.changelog/3306.changed.txt b/.changelog/3306.changed.txt
@@ -0,0 +1 @@
+feat!(metrics): move extra processors after sumologic_schema
diff --git a/deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml b/deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml
@@ -16,14 +16,14 @@ processors:
   - resource
   - k8s_tagger
   - source
+  - sumologic_schema
 {{- if .Values.sumologic.metrics.otelcol.extraProcessors }}
 {{- range $processor := .Values.sumologic.metrics.otelcol.extraProcessors }}
 {{ printf "- %s" ( $processor | keys | first ) | indent 2 }}
 {{- end }}
 {{- end }}
   - resource/remove_k8s_pod_pod_name
   - resource/delete_source_metadata
-  - sumologic_schema
   - transform/set_name
   - groupbyattrs/group_by_name
   - transform/remove_name

diff --git a/docs/v4-migration-doc.md b/docs/v4-migration-doc.md
@@ -256,8 +256,15 @@ require additional action.
   Some Kubernetes objects, for example statefulsets, have a tight (63 characters) limit for their names. Because of that, we truncate the
   prefix that is attached to the names. In particular, the value under key `fullnameOverride` will be truncated to 22 characters.
 
+- Moving extra processors in metrics pipeline after sumologic_schema processor
+
+  This has been changed in order to make the behaviour consistent with the logs pipeline. Now, the extra processors should use [translated
+  versions of some attributes][attribute_translation].
+
 [application_metrics_annotation]: ./collecting-application-metrics.md#application-metrics-are-exposed-one-endpoint-scenario
 [kubernetes_metrics_v3]:
   https://github.com/SumoLogic/sumologic-kubernetes-collection/blob/release-v3/docs/collecting-kubernetes-metrics.md#collecting-kubernetes-metrics
 [otel_metrics_filter]: ./collecting-application-metrics.md#filtering-metrics
 [v3_migration_guide]: ./v3-migration-doc.md
+[attribute_translation]:
+  https://github.com/SumoLogic/sumologic-otel-collector/tree/v0.85.0-sumo-0/pkg/processor/sumologicschemaprocessor#attribute-translation
diff --git a/tests/helm/metrics_test.go b/tests/helm/metrics_test.go
@@ -126,12 +126,12 @@ func TestMetadataMetricsOtelConfigExtraProcessors(t *testing.T) {
 		"resource",
 		"k8s_tagger",
 		"source",
+		"sumologic_schema",
 		"filter/1",
 		"transform/rename_metric",
 		"transform/rename_metadata",
 		"resource/remove_k8s_pod_pod_name",
 		"resource/delete_source_metadata",
-		"sumologic_schema",
 		"transform/set_name",
 		"groupbyattrs/group_by_name",
 		"transform/remove_name",

diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/additional_endpoints.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/additional_endpoints.output.yaml
@@ -187,9 +187,9 @@ data:
           - resource
           - k8s_tagger
           - source
+          - sumologic_schema
           - resource/remove_k8s_pod_pod_name
           - resource/delete_source_metadata
-          - sumologic_schema
           - transform/set_name
           - groupbyattrs/group_by_name
           - transform/remove_name

diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/basic.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/basic.output.yaml
@@ -185,9 +185,9 @@ data:
           - resource
           - k8s_tagger
           - source
+          - sumologic_schema
           - resource/remove_k8s_pod_pod_name
           - resource/delete_source_metadata
-          - sumologic_schema
           - transform/set_name
           - groupbyattrs/group_by_name
           - transform/remove_name

diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/custom.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/custom.output.yaml
@@ -291,9 +291,9 @@ data:
           - resource
           - k8s_tagger
           - source
+          - sumologic_schema
           - resource/remove_k8s_pod_pod_name
           - resource/delete_source_metadata
-          - sumologic_schema
           - transform/set_name
           - groupbyattrs/group_by_name
           - transform/remove_name

diff --git a/tests/helm/testdata/goldenfile/metadata_metrics_otc/filtered_app_metrics.output.yaml b/tests/helm/testdata/goldenfile/metadata_metrics_otc/filtered_app_metrics.output.yaml
@@ -209,9 +209,9 @@ data:
           - resource
           - k8s_tagger
           - source
+          - sumologic_schema
           - resource/remove_k8s_pod_pod_name
           - resource/delete_source_metadata
-          - sumologic_schema
           - transform/set_name
           - groupbyattrs/group_by_name
           - transform/remove_name