-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otelcolLogs): Split kubelet from systemd logs with a separate feature flag #3845
base: main
Are you sure you want to change the base?
Conversation
@@ -213,6 +212,7 @@ data: | |||
- update-ca-certificates.service | |||
- user-cloudinit.service | |||
- var-lib-etcd2.service | |||
- kubelet.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, is there a reason to move kubelet.service
to the end? looks like this was in alphabetical order 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In config yaml since we have splitted systemd and kubelet with separate flags, all systemd units come first and kubelet after those. Previously since kubelet was as subset of systemd, we have kept systemd units in alphabetical order.
@chan-tim-sumo
What is it that you cannot achieve using the existing sumologic.logs.kubelet.* knobs? To "disable kubelet independently of systemd", as the JIRA ticket mentions, why not, for example, use |
I feel that that would be like a workaround , we already have suggested other workaround to the customer who raised this, https://help.sumologic.com/docs/send-data/kubernetes/collecting-logs/#kubelet-logs |
@jagan2221 I think for changes like these we need new integration tests since this is change to a major feature (logs collection) |
Split kubelet logs from systemd logs and provided a separate feature flag(sumologic.logs.kubelet.enabled) to toggle kubelet logs collection.
Why?
Currently, if sumologic.logs.systemd.enabled flag We have already mentioned in docs that kubelet logs can be configured separately, but haven't provided provision for that.
Ref JIRA -> https://sumologic.atlassian.net/browse/OSC-784
Checklist