Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otelcolLogs): Split kubelet from systemd logs with a separate feature flag #3845

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

jagan2221
Copy link

@jagan2221 jagan2221 commented Sep 16, 2024

Split kubelet logs from systemd logs and provided a separate feature flag(sumologic.logs.kubelet.enabled) to toggle kubelet logs collection.

Why?
Currently, if sumologic.logs.systemd.enabled flag We have already mentioned in docs that kubelet logs can be configured separately, but haven't provided provision for that.

Ref JIRA -> https://sumologic.atlassian.net/browse/OSC-784

Checklist

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@jagan2221 jagan2221 requested a review from a team as a code owner September 16, 2024 05:17
@@ -213,6 +212,7 @@ data:
- update-ca-certificates.service
- user-cloudinit.service
- var-lib-etcd2.service
- kubelet.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, is there a reason to move kubelet.service to the end? looks like this was in alphabetical order 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/3845/files#diff-bd3221290637efd3855e2de7717869ccb4e6eb4cf2dcc177729dd61e9cb2fe06R121

In config yaml since we have splitted systemd and kubelet with separate flags, all systemd units come first and kubelet after those. Previously since kubelet was as subset of systemd, we have kept systemd units in alphabetical order.
@chan-tim-sumo

@ccressent
Copy link

What is it that you cannot achieve using the existing sumologic.logs.kubelet.* knobs?

To "disable kubelet independently of systemd", as the JIRA ticket mentions, why not, for example, use sumologic.logs.kubelet.otelcol.extraProcessors and create an appropriate filter that drops everything?

@jagan2221
Copy link
Author

https://sumologic.atlassian.net/browse/OSC-784

I feel that that would be like a workaround , we already have suggested other workaround to the customer who raised this,
#3168 (comment) - This thread has customer's concern using the workaround and Dominik mentioning about separating kubelet in future.

https://help.sumologic.com/docs/send-data/kubernetes/collecting-logs/#kubelet-logs
Also here we are mentioning the significance of kubelet logs and that can be configured separately as well.
@ccressent

@rnishtala-sumo
Copy link
Contributor

@jagan2221 I think for changes like these we need new integration tests since this is change to a major feature (logs collection)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants