Don't use race detector for jobreceiver tests#1639
Merged
Conversation
This commit overrides the race detection in the jobreceiver tests. While this prevents us from catching data races in the jobreceiver in CI, it also keeps CI from failing sporadically on Darwin. There's something amiss in the jobreceiver tests and it causes CI to fail quite regularly, almost always on Darwin. I suspect there is some concurrency bug in the test harness that is more likely to deadlock when the race detector is enabled. (The race detector slows everything down, and that can make deadlocks more likely to happen by exposing timing bugs). Signed-off-by: Eric Chlebek <echlebek@sumologic.com>
Contributor
sumo-drosiek
left a comment
sumo-drosiek
left a comment
There was a problem hiding this comment.
Could you add an issue, so we do not loose track on it and eventually investigate in the future?
Contributor
Author
|
Good idea. Filed #1641 |
chan-tim-sumo
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit overrides the race detection in the jobreceiver tests. While this prevents us from catching data races in the jobreceiver in CI, it also keeps CI from failing sporadically on Darwin.
There's something amiss in the jobreceiver tests and it causes CI to fail quite regularly, almost always on Darwin. I suspect there is some concurrency bug in the test harness that is more likely to deadlock when the race detector is enabled. (The race detector slows everything down, and that can make deadlocks more likely to happen by exposing timing bugs).