Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad units in call to pvlib.pvsystem.sapm #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bad units in call to pvlib.pvsystem.sapm #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pvmismatch/contrib/gen_coeffs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ def gen_iec_61853_from_sapm(pvmodule):
Module is a dictionary according to ``pvlib.pvsystem.sapm``.
"""
tc, irr = TEST_MAT
return sapm(irr / 1000.0, tc, pvmodule)
# sapm in pvlib.pvsystem expects effective_irradiance in W/m2, temp_cell in degrees Celsius
return sapm(irr, tc, pvmodule)


def gen_two_diode(isc, voc, imp, vmp, nseries, nparallel,
Expand Down