YouTube Embeds And Styling Improvement #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now shows a loader with thumbnail on top of YouTube embed till its ready. Fixed events and little styling.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ravikumawat7716
requested changes
Sep 15, 2024
Updated Spinner color for better consistency.
|
@ravikumawat7716 I have updated the spinner css now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description:
The main problem regarding UX of the site was that on slower systems, so many YT embeds on home page and gallery take a long time to load. Until they load, the whole page is blank.
The events on home page were not getting updated due to old backend (camlio.shop). Also in the events route, the event title was not visible in dark mode.
Freecounterstat is down since 2 days, and the whole page keeps waiting for 1min+ for it to load.
Changes:
Now shows a loader with thumbnail on top of YouTube embed until the player is finished rendering.
Updated home page event code, now showing last 3 events. Fixed the font color issue in events route.
Temporarily removed freecounterstat code. I don't think it will be up now. We can create our own by storing count in the backend in future.
Fixed some minor styling issues in google login and clubs (There was an out of place white banner visible in dark mode below the google sign in button.)
Removed fetchAdmins function from homepage as we are not displaying the council members on home page.
Checklist:
Additional Notes:
IITM Email - [email protected]