Create MediaMail calculator #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjriga
force-pushed
the
kendra/tj-217-write-solidususpscalculatormediamail-calculator
branch
5 times, most recently
from
a8d5133 to
54b683f
Compare
kjriga
force-pushed
the
kendra/tj-217-write-solidususpscalculatormediamail-calculator
branch
from
54b683f to
e2e09f5
Compare
benjaminwil
approved these changes
Oct 6, 2025
| module SolidusUsps | ||
| module Calculator | ||
| class MediaMail < SolidusUsps::Calculator::Base | ||
| MEDIA_MAIL_CATEGORY_NAME = "Media Mail".freeze |
There was a problem hiding this comment.
Nit: This constant is defined the MediaMail class so MEDIA_MAIL_ is a redundant prefix in the end. Suggestion:
- SolidusUsps::Calculator::MediaMail::MEDIA_MAIL_CATEGORY_NAME
+ SolidusUsps::Calculator::MediaMail::CATEGORY_NAME
kjriga
force-pushed
the
kendra/tj-217-write-solidususpscalculatormediamail-calculator
branch
3 times, most recently
from
c693cb0 to
6b64c90
Compare
|
Fixed Benjamin's comments. I also updated this calculator to preemptively add the new |
kjriga
force-pushed
the
kendra/tj-217-write-solidususpscalculatormediamail-calculator
branch
from
6b64c90 to
3a1b421
Compare
From TJ, we need this. It relies on shipping category for calculating availability, which I added a seed and README info to.
kjriga
force-pushed
the
kendra/tj-217-write-solidususpscalculatormediamail-calculator
branch
from
3a1b421 to
5b43bea
Compare
adammathys
deleted the
kendra/tj-217-write-solidususpscalculatormediamail-calculator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting over the MediaMail calculator from TJ. I added a seed file to ensure the required shipping category can be made if desired, to use this calculator.