Make thrown bombs explode on impact #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkubax10
added
involves:functionality
type:feature
category:code
status:needs-review
|
OK, I did the wall impact thingy for walls and ceilings. |
fix a few bugs with GoldBomb
Narre
changed the title
Rusty-Box
approved these changes
Aug 21, 2023
Vankata453
reviewed
Aug 22, 2023
Vankata453
approved these changes
Aug 22, 2023
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2574.
This PR implements the "explode on impact with other enemies" part + it makes thrown bombs explode on contact with the (a) player.
I'm not sure about the exploding on impact with walls part. It could potentially be based either on whether the hit wall is a vertical wall or a horizontal floor/ceiling, or on the thrown bomb's velocity, but I think it would be better if the bomb doesn't explode when hitting a wall at all.As requested by Rusty, I made it so that the bombs will explode upon being thrown at walls and ceilings, but not floors.