Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now every Windows result in docs/VALIDATION.md came from Wine on Linux. This adds
.github/workflows/windows.yml, which runs the Windows build on a GitHub-hosted Windows runner.build (ubuntu-latest):
nix build .#msi .#host-windows, then uploads the MSI,portable-host.exe,SDL3.dll, andtests/replayas one artifact.windows (windows-latest, needs build):
msiexec /i … /qn /l*v install.log;C:\Program Files\Portable Hostholds exactly the four packaged files (the host and DLL byte-identical to the build's), and that Windows lists the product as installed;WScript.Shell;tests/replayagainst its golden trace with the installed host and component, and runsinspect;msiexec /x … /qnand checks that nothing is left.Every step adds its results to the run's summary, and the logs and screenshots are uploaded as the
windows-runartifact.README.md and docs/VALIDATION.md will record what the runs show (runner image and version, renderer) and what is still not covered: signing, SmartScreen, and a person playing.
Draft until the workflow passes.
🤖 Generated with Claude Code