Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1103,duplicated PR] Added the jpg output format as apart of the PNG, improve for compatibility #1148

Closed
wants to merge 2 commits into from

Conversation

Gary709
Copy link

@Gary709 Gary709 commented Oct 28, 2023

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are
required for this change.
Add a new JPG output format which suits for devices that do not support PNG
Users can self-select their preferred format
Here's a demo video
https://github.com/Swati4star/Images-to-PDF/assets/97233980/953a7d3d-7365-4338-8540-2a01b1211cfe

video demo

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
The demo video shows that when PDF is converted to image, it will generate both PNG and JPG files.
Screenshot 2023-10-28 at 1 47 37 pm
Screenshot 2023-10-28 at 1 47 31 pm

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2023

Code Climate has analyzed commit 596a437 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@Gary709
Copy link
Author

Gary709 commented Oct 28, 2023

Okay, I will fixed the complexity error

@Gary709 Gary709 closed this Oct 28, 2023
@Gary709 Gary709 reopened this Oct 28, 2023
@Gary709
Copy link
Author

Gary709 commented Oct 28, 2023

Fixed complexity error, added JavaDoc, comments. etc

@Gary709 Gary709 closed this Oct 28, 2023
@Gary709 Gary709 reopened this Oct 28, 2023
@Gary709 Gary709 changed the title Added the jpg output format as apart of the PNG, improve for compatibility [#1103] Added the jpg output format as apart of the PNG, improve for compatibility Oct 29, 2023
@Gary709 Gary709 closed this Oct 29, 2023
@Gary709 Gary709 deleted the support_jpg_image_output branch October 29, 2023 06:11
@Gary709 Gary709 changed the title [#1103] Added the jpg output format as apart of the PNG, improve for compatibility [#1103,duplicated PR] Added the jpg output format as apart of the PNG, improve for compatibility Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant