Dtzer0/UI/main #20
Open
Dtzer0/UI/main #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # MarketApp/MarketApp.xcodeproj/project.pbxproj # MarketApp/MarketApp/Component/CartView.swift # MarketApp/MarketApp/ProductList/MainView.swift # MarketApp/MarketApp/View/ProductDetail/InfoViewModel.swift # MarketApp/MarketApp/View/ProductDetail/ProductView.swift
…MAIN # Conflicts: # MarketApp/MarketApp/Component/CartView.swift # MarketApp/MarketApp/View/ProductDetail/ProductView.swift
통신은 성공했으나, LazyVGrid에 문제가 있습니다.
Roy-wonji
reviewed
Mar 10, 2023
| import ExytePopupView | ||
|
|
||
| //MARK : 커뮤니티 | ||
| let dateformat: DateFormatter = { |
There was a problem hiding this comment.
@Dtzer0 여기는 공용 파일을 만들어서 분해 하는거 어떨까요 ??
| } | ||
| } | ||
|
|
||
| struct WriteComments : View { |
There was a problem hiding this comment.
@Dtzer0 한파일에 뷰가 두개가 있네요 파일 을 분해해서 각각 사용 하는 거 어떨까요 ??
왜 저헐게 한파일레 두개의 뷰를 만들었나용 ??
There was a problem hiding this comment.
둘 다 커뮤니티 뷰에 속하는 뷰라서 하나에 다 넣은거에요! 하나는 댓글목록UI고 하나는 댓글textfield에요.
| .nanumSquareNeo(family: .cBd, size: 15, color: .black) | ||
| }) | ||
| } | ||
| }//동작안함. ( bp해두고 돌려봤을때는 잘찍힘 ) |
There was a problem hiding this comment.
@Dtzer0 button에서 액션을 해줘야 팝업이 나올거 같아요!
|
|
||
| ScrollView { | ||
| VStack { | ||
| DetailInfo() |
There was a problem hiding this comment.
@Dtzer0 코드가 짧아졌네용 ㅎㅎ 역시 점점 느시는 군요
| .font(.system(size: 18, weight: .medium, design: .default)) | ||
| }.frame(width: 50) | ||
| } | ||
| .padding(.top, 10) |
There was a problem hiding this comment.
@Dtzer0 이런 경우는 padding을 vertical을 주는거 어떨까요 ??
Roy-wonji
reviewed
Mar 13, 2023
|
|
||
| import SwiftUI | ||
|
|
||
| enum demoImage : String, CaseIterable { |
There was a problem hiding this comment.
@Dtzer0 이거는 따로 파일을 분리 하는거 어떤가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem1 : 텍스트필드를 맨아래에두면 Product.view의 전체 스크롤뷰에 의해 커뮤니티 댓글계수만큼 텍스트필드가 아래로 밀리는현상 발생
Problem2 : 해서 팝업으로 아예 막으려했는데 돌기만하고 프리뷰에는 뜨지않는 현상 발생
참고부탁드립니다. 일단 작업한것부터 올릴게요.