Skip to content

Conversation

@eikek
Copy link
Member

@eikek eikek commented Sep 25, 2025

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1019.dev.renku.ch

@eikek eikek changed the title Attempt to suppor dockerhub private images feat: Attempt to support dockerhub private images Sep 25, 2025
@coveralls
Copy link

coveralls commented Sep 25, 2025

Pull Request Test Coverage Report for Build 18123243513

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 70 of 101 (69.31%) changed or added relevant lines in 9 files are covered.
  • 106 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.01%) to 86.702%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/connected_services/models.py 3 4 75.0%
components/renku_data_services/connected_services/blueprints.py 8 10 80.0%
components/renku_data_services/notebooks/image_check.py 1 4 25.0%
components/renku_data_services/notebooks/api/classes/image.py 4 8 50.0%
components/renku_data_services/notebooks/core_sessions.py 2 6 33.33%
components/renku_data_services/connected_services/db.py 20 37 54.05%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/connected_services/db.py 1 73.48%
components/renku_data_services/notebooks/api/classes/image.py 1 84.88%
components/renku_data_services/crc/models.py 1 81.47%
components/renku_data_services/storage/blueprints.py 2 92.68%
components/renku_data_services/notebooks/image_check.py 12 38.96%
components/renku_data_services/notebooks/core_sessions.py 89 18.36%
Totals Coverage Status
Change from base Build 17939463871: -0.01%
Covered Lines: 22357
Relevant Lines: 25786

💛 - Coveralls

@eikek eikek force-pushed the eikek/feat/dockerhub-private-images branch from 117261b to 8c169e0 Compare September 26, 2025 06:37
$ref: "#/components/responses/Error"
tags:
- oauth2
/oauth2/providers/{provider_id}/simple_connect:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general remark: I think this API endpoint should be relocated somewhere else. It should not have oauth2 in the path when this is to handle third-party platforms which DO NOT implement OAuth 2.0.

Some suggestions: /integrations/..., /non-oauth2/..., /providers/..., etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants