-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Attempt to support dockerhub private images #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You can access the deployment of this PR at https://renku-ci-ds-1019.dev.renku.ch |
Pull Request Test Coverage Report for Build 18123243513Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
117261b to
8c169e0
Compare
| $ref: "#/components/responses/Error" | ||
| tags: | ||
| - oauth2 | ||
| /oauth2/providers/{provider_id}/simple_connect: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general remark: I think this API endpoint should be relocated somewhere else. It should not have oauth2 in the path when this is to handle third-party platforms which DO NOT implement OAuth 2.0.
Some suggestions: /integrations/..., /non-oauth2/..., /providers/..., etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, good point!
/deploy