Skip to content

Conversation

@leafty
Copy link
Member

@leafty leafty commented Oct 15, 2025

Closes #1009.

⚠️ Includes API breaking changes ⚠️

Allows data connectors to be skipped when launching a session.

UI update: SwissDataScienceCenter/renku-ui#3873.

Note: more related changes can be found in #1068.

/deploy renku-ui=leafty/feat-allow-dc-skip

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1065.dev.renku.ch

@coveralls
Copy link

coveralls commented Oct 15, 2025

Pull Request Test Coverage Report for Build 18707793088

Details

  • 36 of 59 (61.02%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.006%) to 86.825%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/blueprints.py 0 1 0.0%
components/renku_data_services/notebooks/core_sessions.py 4 26 15.38%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/notebooks/blueprints.py 1 76.84%
components/renku_data_services/data_connectors/doi/metadata.py 2 70.67%
components/renku_data_services/notebooks/core_sessions.py 2 17.39%
Totals Coverage Status
Change from base Build 18690049033: 0.006%
Covered Lines: 22723
Relevant Lines: 26171

💛 - Coveralls

@leafty leafty force-pushed the leafty/feat-1009-allow-dc-skip branch from 5051fe0 to 7e8ece6 Compare October 17, 2025 07:39
@leafty leafty marked this pull request as ready for review October 17, 2025 12:08
@leafty leafty requested review from a team, SalimKayal and sgaist as code owners October 17, 2025 12:08
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Flora. Just 2 small changes to remove leftover stuff from developing this.

@leafty leafty requested a review from olevski October 22, 2025 06:47
@leafty leafty merged commit 5cc2b39 into main Oct 22, 2025
56 of 58 checks passed
@leafty leafty deleted the leafty/feat-1009-allow-dc-skip branch October 22, 2025 11:32
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data connectors in sessions: allow skip

5 participants