Skip to content

fix: do not pass awaitable in __get_gitlab_image_pull_secret #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix: do not pass awaitable in __get_gitlab_image_pull_secret #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/renku_data_services/notebooks/core_sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,12 @@ def get_auth_secret_anonymous(nb_config: NotebooksConfig, server_name: str, requ
return ExtraSecret(secret)


def __get_gitlab_image_pull_secret(
async def __get_gitlab_image_pull_secret(
nb_config: NotebooksConfig, user: AuthenticatedAPIUser, image_pull_secret_name: str, access_token: str
) -> ExtraSecret:
"""Create a Kubernetes secret for private GitLab registry authentication."""

k8s_namespace = nb_config.k8s_client.namespace()
k8s_namespace = await nb_config.k8s_client.namespace()

registry_secret = {
"auths": {
Expand Down Expand Up @@ -605,7 +605,7 @@ async def get_image_pull_secret(
):
needs_pull_secret = await __requires_image_pull_secret(nb_config, image, internal_gitlab_user)
if needs_pull_secret:
v1_secret = __get_gitlab_image_pull_secret(
v1_secret = await __get_gitlab_image_pull_secret(
nb_config, user, f"{server_name}-image-secret-v1", internal_gitlab_user.access_token
)
return v1_secret
Expand Down