-
Notifications
You must be signed in to change notification settings - Fork 6
chore: add prettier plugin to sort imports #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can access the deployment of this PR at https://renku-ci-ui-3886.dev.renku.ch |
6907092 to
ad3d893
Compare
|
Note: OK to use prettier plugin, we should check that imports are OK with the change. |
ad3d893 to
86a0985
Compare
| "plugins": [ | ||
| "@ianvs/prettier-plugin-sort-imports" | ||
| ], | ||
| "importOrderCaseSensitive": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this option? I tested this locally and it sorts the import blocks neatly.
| "importOrderCaseSensitive": false | |
| "importOrderCaseSensitive": false, | |
| "importOrder": [ | |
| "", | |
| "<THIRD_PARTY_MODULES>", | |
| "", | |
| "^(?!.*[.]s?css$)[./].*$", | |
| "", | |
| ".s?css$" | |
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍 98cf27e
leafty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Add a prettier plugin to automatically sort imports
/deploy