Skip to content

Conversation

@lorenzo-cavazzi
Copy link
Member

Add a prettier plugin to automatically sort imports

/deploy

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3886.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi force-pushed the lorenzo/autosort-imports branch from 6907092 to ad3d893 Compare October 23, 2025 08:36
@leafty
Copy link
Member

leafty commented Oct 27, 2025

Note: OK to use prettier plugin, we should check that imports are OK with the change.

@lorenzo-cavazzi lorenzo-cavazzi force-pushed the lorenzo/autosort-imports branch from ad3d893 to 86a0985 Compare October 28, 2025 08:49
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review October 28, 2025 12:43
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner October 28, 2025 12:43
"plugins": [
"@ianvs/prettier-plugin-sort-imports"
],
"importOrderCaseSensitive": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this option? I tested this locally and it sorts the import blocks neatly.

Suggested change
"importOrderCaseSensitive": false
"importOrderCaseSensitive": false,
"importOrder": [
"",
"<THIRD_PARTY_MODULES>",
"",
"^(?!.*[.]s?css$)[./].*$",
"",
".s?css$"
]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍 98cf27e

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@lorenzo-cavazzi lorenzo-cavazzi merged commit 499b644 into main Oct 30, 2025
25 of 30 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the lorenzo/autosort-imports branch October 30, 2025 11:10
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants