Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to data mismatch error #4

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

slinkydeveloper
Copy link
Contributor

See #3

@Swoorup
Copy link
Owner

Swoorup commented Apr 19, 2024

Great, thanks for this.

Can you also add an accompanying test for this? Possibly in https://github.com/Swoorup/arrow-convert/blob/main/arrow_convert/tests/test_deserialize.rs

@slinkydeveloper
Copy link
Contributor Author

Test added @Swoorup

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Swoorup Swoorup merged commit 03725fe into Swoorup:main Apr 19, 2024
5 checks passed
@Swoorup
Copy link
Owner

Swoorup commented Apr 19, 2024

@slinkydeveloper Excellent, I'll push out an update by this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants