Skip to content

Use kernel locale parameters in service definitions #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.14
Choose a base branch
from
Open

Use kernel locale parameters in service definitions #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Bundle/Resources/config/services/controller.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<service id="sylius.resource_controller.flash_helper" class="Sylius\Bundle\ResourceBundle\Controller\FlashHelper" public="false">
<argument type="service" id="request_stack" />
<argument type="service" id="translator" />
<argument>%locale%</argument>
<argument>%kernel.default_locale%</argument>
</service>
<service id="Sylius\Bundle\ResourceBundle\Controller\FlashHelperInterface" alias="sylius.resource_controller.flash_helper" public="false" />

Expand Down
6 changes: 2 additions & 4 deletions src/Bundle/Resources/config/services/integrations/translation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@
<defaults public="true" />

<service id="sylius.translation_locale_provider.immutable" class="Sylius\Resource\Translation\Provider\ImmutableTranslationLocaleProvider">
<argument type="collection">
<argument>%locale%</argument>
</argument>
<argument>%locale%</argument>
<argument>%kernel.enabled_locales%</argument>
<argument>%kernel.default_locale%</argument>
</service>
<service id="Sylius\Component\Resource\Translation\Provider\ImmutableTranslationLocaleProvider" alias="sylius.translation_locale_provider.immutable">
<deprecated package="sylius/resource-bundle" version="1.11">The "%alias_id%" service alias is deprecated since sylius/resource-bundle 1.11 and will be removed in sylius/resource-bundle 2.0. Use Sylius\Resource\Translation\Provider\ImmutableTranslationLocaleProvider instead.</deprecated>
Expand Down
1 change: 1 addition & 0 deletions tests/Application/config/packages/framework.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ framework:
secret: "%secret%"
form: ~
csrf_protection: true
enabled_locales: ["%locale%"]
default_locale: "%locale%"
session:
handler_id: ~
Expand Down