Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Component/legacy/tests/Dummy/DummyClassWithDocBlock.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?php

/*
* This file is part of the Sylius package.
*
* (c) Sylius Sp. z o.o.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

declare(strict_types=1);

namespace Sylius\Component\Resource\Tests\Dummy;

/**
* This docblock for this class explains what to do.
*/
final class DummyClassWithDocBlock
{
}
14 changes: 12 additions & 2 deletions src/Component/legacy/tests/Reflection/ClassReflectionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
use PHPUnit\Framework\TestCase;
use Sylius\Component\Resource\Tests\Dummy\DummyClassOne;
use Sylius\Component\Resource\Tests\Dummy\DummyClassTwo;
use Sylius\Component\Resource\Tests\Dummy\DummyClassWithDocBlock;
use Sylius\Component\Resource\Tests\Dummy\TraitPass;
use Sylius\Resource\Annotation\SyliusCrudRoutes;
use Sylius\Resource\Annotation\SyliusRoute;
Expand All @@ -38,16 +39,25 @@ public function it_returns_resource_classes_from_paths(): void
/** @test */
public function it_returns_resource_classes_from_a_directory(): void
{
$resources = ClassReflection::getResourcesByPath(__DIR__ . '/../Dummy');
$resources = iterator_to_array(ClassReflection::getResourcesByPath(__DIR__ . '/../Dummy'));

$this->assertContains(DummyClassOne::class, $resources);
$this->assertContains(DummyClassTwo::class, $resources);
}

/** @test */
public function it_excludes_docblock_comments(): void
{
$resources = iterator_to_array(ClassReflection::getResourcesByPath(__DIR__ . '/../Dummy'));

$this->assertContains(DummyClassWithDocBlock::class, $resources);
$this->assertNotContains('This docblock for this class explains what to do', $resources);
}

/** @test */
public function it_excludes_traits(): void
{
$resources = ClassReflection::getResourcesByPath(__DIR__ . '/../Dummy');
$resources = iterator_to_array(ClassReflection::getResourcesByPath(__DIR__ . '/../Dummy'));

$this->assertNotContains(TraitPass::class, $resources);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Component/src/Reflection/ClassReflection.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public static function getResourcesByPath(string $path): iterable

$namespace = $matches[1] ?? null;

if (!preg_match('/class\s+(\w+)/', $fileContent, $matches)) {
if (!preg_match('/^(?:\s*(?:final|abstract|readonly)\s+)*class\s+(\w+)/mi', $fileContent, $matches)) {
// no class found
continue;
}
Expand Down
Loading