[UPMERGE] 1.13 -> 1.14 #1067
Open
[UPMERGE] 1.13 -> 1.14 #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT
…use CreatePaginatorTrait (#1063) | Q | A | --------------- | ----- | Bug fix? | yes (better error message) | New feature? | | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT When using the "make:entity", a repository is created automatically, and normally it can be used directly with the new routing system without implementing the Sylius repository interface. But here, in a collection operation, we define this createPaginator by default. So here, first, the idea is to be more precise on what's happening when the default method and suggest using CreatePaginatorTrait. That's another point, but we should also warn (or just fix it) about a non-grid object on the BootstrapAdminUi grid template. Before <img width="1067" height="482" alt="image" src="https://github.com/user-attachments/assets/fc0c2dbf-2ad9-4d87-a517-ba1d91ecb5e1" /> After <img width="1067" height="482" alt="image" src="https://github.com/user-attachments/assets/0dbff1ef-d1d2-411b-8f7a-ef1a132481f1" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been generated automatically.
For more details see upmerge_pr.yaml.
Remember! The upmerge should always be merged with using
Merge pull requestbutton.In case of conflicts, please resolve them manually with usign the following commands:
If you use other name for the upstream remote, please replace
upstreamwith the name of your remote pointing to theSylius/SyliusResourceBundlerepository.Once the conflicts are resolved, please run
git merge --continueand push the changes to this PR.