PHPSpec to PHPUnit DependencyInjection #1074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glancu
commented
Oct 27, 2025
Glancu
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Member
|
Please split into 2 commits:
|
Member
Hi @loic425! Just to better understand your reasoning, could you explain why this level of separation into two commits is important in your view? From my perspective, it feels a bit excessive in this particular case, especially since the PR is already quite granular and focused only on specific directory. I'm curious what concrete benefits you see in splitting it this way. 🤔 |
Member
|
When splitting into 2 commits we can review the diff in the first commit. Look at the current PRs inside the Grid package, and you'll see the diff. On my OpenCode, I've split this into two tasks. |
Glancu
force-pushed
the
Glancuphpspec-to-phpunit-dependency-injection
branch
from
0864af4 to
cf63259
Compare
Glancu
force-pushed
the
Glancuphpspec-to-phpunit-dependency-injection
branch
from
cf63259 to
dfaa96c
Compare
…ncy-injection' into Glancuphpspec-to-phpunit-dependency-injection # Conflicts: # src/Bundle/spec/DependencyInjection/Compiler/Helper/TargetEntitiesResolverSpec.php # src/Bundle/spec/DependencyInjection/Driver/Exception/InvalidDriverExceptionSpec.php # src/Bundle/spec/DependencyInjection/Driver/Exception/UnknownDriverExceptionSpec.php
Glancu
force-pushed
the
Glancuphpspec-to-phpunit-dependency-injection
branch
from
6f5323d to
cf63259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.