[UPMERGE] 1.13 -> 1.14 #1077
[UPMERGE] 1.13 -> 1.14 #1077
Conversation
| Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT
…use CreatePaginatorTrait (#1063) | Q | A | --------------- | ----- | Bug fix? | yes (better error message) | New feature? | | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT When using the "make:entity", a repository is created automatically, and normally it can be used directly with the new routing system without implementing the Sylius repository interface. But here, in a collection operation, we define this createPaginator by default. So here, first, the idea is to be more precise on what's happening when the default method and suggest using CreatePaginatorTrait. That's another point, but we should also warn (or just fix it) about a non-grid object on the BootstrapAdminUi grid template. Before <img width="1067" height="482" alt="image" src="https://github.com/user-attachments/assets/fc0c2dbf-2ad9-4d87-a517-ba1d91ecb5e1" /> After <img width="1067" height="482" alt="image" src="https://github.com/user-attachments/assets/0dbff1ef-d1d2-411b-8f7a-ef1a132481f1" />
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {% endfor %} | ||
| {% endif %} |
There was a problem hiding this comment.
The template now tries to handle operations without a grid by defaulting definition to null and showing a fallback message, but the bulk‑action block still dereferences definition.actionGroups before any null check. When the operation returns non‑grid data, this condition is evaluated first and Twig throws a runtime error instead of rendering the fallback message. Wrap the bulk‑action logic in an if definition guard before accessing its properties.
Useful? React with 👍 / 👎.
loic425
force-pushed
the
upmerge/1.13_1.14
branch
from
9b68501 to
5b8b063
Compare
SyliusBot
force-pushed
the
upmerge/1.13_1.14
branch
from
5b8b063 to
9302384
Compare
This PR has been generated automatically.
For more details see upmerge_pr.yaml.
Remember! The upmerge should always be merged with using
Merge pull requestbutton.In case of conflicts, please resolve them manually with usign the following commands:
If you use other name for the upstream remote, please replace
upstreamwith the name of your remote pointing to theSylius/SyliusResourceBundlerepository.Once the conflicts are resolved, please run
git merge --continueand push the changes to this PR.