Skip to content

Commit

Permalink
bug #136 Revert "Remove performNoDeepMerging to authorise additional …
Browse files Browse the repository at this point in the history
…custom theme folders" (GSadee)

This PR was merged into the 2.4 branch.

Discussion
----------

Reverts #128

I did not notice that in the PR the tests were not included and this actually changes the expected behaviour. This change has been explained in the PR, but I still have some doubts and IMO it should be further investigated how the Theme Bundle will behave in the case of the several directories specified.

Commits
-------

69100dc Revert "Remove performNoDeepMerging to authorise additional custom theme folders"
  • Loading branch information
GSadee authored Jul 19, 2024
2 parents e956d29 + 69100dc commit d2f28db
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public function buildConfiguration(ArrayNodeDefinition $node): void
->arrayNode('directories')
->defaultValue(['%kernel.project_dir%/themes'])
->requiresAtLeastOneElement()
->performNoDeepMerging()
->prototype('scalar')
;
}
Expand Down

0 comments on commit d2f28db

Please sign in to comment.