Fix ThemeCollector Symfony 7 compatibility #134
Conversation
| @@ -60,7 +55,7 @@ public function getUsedTheme(): ?ThemeInterface | |||
| } | |||
|
|
|||
| /** | |||
| * @return array|ThemeInterface[] | |||
| * @return ThemeInterface[] | |||
There was a problem hiding this comment.
see phpdoc above
| * | ||
| * @psalm-suppress NonInvariantDocblockPropertyType | ||
| */ | ||
| protected $data; |
There was a problem hiding this comment.
This variable is defined by DataCollector itself. With beginning of Symfony 7 it has a Union Type here: https://github.com/symfony/symfony/blob/1a16ebc32598faada074e0af12a6a698d2964a5e/src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php#L31
For BC reasons best is to move this variable to PHPDoc definition. So we can support Symfony 7 and previous versions of the parent collector class.
| "tests/Application/bin/console lint:container --env dev", | ||
| "tests/Application/bin/console lint:container --env prod" |
There was a problem hiding this comment.
Stumbled now over that you also have a working console the lint:container would also catch such errors. I recommend always lint for dev and prod container as they may have different set of services.
Co-authored-by: Grzegorz Sadowski <[email protected]>
|
Thank you, Alexander! 🥇 |
I added a very simple test case which just init the ThemeCollector to catch this.