feat(accountsdb): add allocator param to get methods #958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sobeston
force-pushed
the
sobe/accountsdb/cleanup
branch
4 times, most recently
from
50f0eec to
322364a
Compare
dnut
changed the title
dnut
requested changes
Sep 29, 2025
Sobeston
force-pushed
the
sobe/accountsdb/cleanup
branch
from
322364a to
1c81af9
Compare
InKryption
reviewed
Sep 30, 2025
| return .{ | ||
| .lamports = account.lamports, | ||
| .data = .{ .owned_allocation = data }, | ||
| .data = .{ .unowned_allocation = account.data }, |
There was a problem hiding this comment.
Why not also just duplicate this data? This seems like it would be unsound in the event that we implement "cleaning logic" on this impl which runs while a caller is still holding onto their reference to it.
There was a problem hiding this comment.
We clone accounts on put, meaning that the ThreadSafeAccountMap itself owns all the account datas by this point already. If the caller calls .deinit() on the accounts they get from .get(), that's a no-op.
in the event that we implement "cleaning logic" on this impl which runs while a caller is still holding onto their reference to it.
I think we'd need to refcount the accounts in this case (or something equivalent), so that's out of scope
Sobeston
force-pushed
the
sobe/accountsdb/cleanup
branch
from
1c81af9 to
2750563
Compare
dnut
previously approved these changes
Oct 2, 2025
dnut
previously approved these changes
Oct 3, 2025
InKryption
previously approved these changes
Oct 3, 2025
Sobeston
force-pushed
the
sobe/accountsdb/cleanup
branch
from
83dbabd to
87c0c63
Compare
InKryption
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main objective: add an allocator parameter to account gets - call sites currently rely on using the accountsdb allocator, which is pointless